Need advise on resolving error in dataman module

priyablue commented 6 years ago

Due to instability in the module "dataman" module , I hereby uploaded the uncleaned version with git and other modules so it would be easier to clean the dataman package. As mentioned in the previous issue, the mc_pos_control has been resolved.

The issue with dataman starts here.

The module navigator and the packages which depends on navigator has been modified.
The dataman package gives out the error during make process as given below:

In file included from ../src/systemcmds/tests/test_dataman.c:59: ../src/modules/dataman/dataman.h:89:36: fatal error: use of undeclared identifier 'NUM_MISSIONS_SUPPORTED' DM_KEY_WAYPOINTS_OFFBOARD_0_MAX = NUM_MISSIONS_SUPPORTED, ^ 1 error generated.

if this is being resolved by commenting / removing waypoints, then this is affecting in the src/modules/mavlink due to which a high impact is created during build. Especially the files mavlink_messages.cpp & mavlink_receiver.cpp is highly depending on this dataman.

Kindly advise on this.

aditya00j commented 6 years ago

Hi, I did a clean clone from your branch (error_branch), and ran "make px4fmu-v3_default". I am getting a cmake error even before I reach the dataman part which you want me to investigate. Here is the error log. I think you'll have to resolve the cmake errors first. Please do a clean clone of the branch and try running the above command.

-- CMAKE_MODULE_PATH: /Users/aditya/Documents/GX_error/cmake
-- Nuttx build for px4fmu-v3 on m4 hardware, using nsh with ROMFS on px4fmu_common
-- Build Type: MinSizeRel
Traceback (most recent call last):
  File "Tools/tag_to_version.py", line 19, in <module>
    minor = res[1]
IndexError: list index out of range
-- PX4 VERSION: bdc382497
-- CONFIG: nuttx-px4fmu-v3-default
CMake Deprecation Warning at /Users/aditya/anaconda/share/cmake-3.6/Modules/CMakeForceCompiler.cmake:79 (message):
  The CMAKE_FORCE_C_COMPILER macro is deprecated.  Instead just set
  CMAKE_C_COMPILER and allow CMake to identify the compiler.
Call Stack (most recent call first):
  cmake/toolchains/Toolchain-arm-none-eabi.cmake:31 (cmake_force_c_compiler)
  /Users/aditya/anaconda/share/cmake-3.6/Modules/CMakeDetermineSystem.cmake:98 (include)
  CMakeLists.txt:275 (project)

CMake Deprecation Warning at /Users/aditya/anaconda/share/cmake-3.6/Modules/CMakeForceCompiler.cmake:93 (message):
  The CMAKE_FORCE_CXX_COMPILER macro is deprecated.  Instead just set
  CMAKE_CXX_COMPILER and allow CMake to identify the compiler.
Call Stack (most recent call first):
  cmake/toolchains/Toolchain-arm-none-eabi.cmake:37 (cmake_force_cxx_compiler)
  /Users/aditya/anaconda/share/cmake-3.6/Modules/CMakeDetermineSystem.cmake:98 (include)
  CMakeLists.txt:275 (project)

CMake Deprecation Warning at /Users/aditya/anaconda/share/cmake-3.6/Modules/CMakeForceCompiler.cmake:79 (message):
  The CMAKE_FORCE_C_COMPILER macro is deprecated.  Instead just set
  CMAKE_C_COMPILER and allow CMake to identify the compiler.
Call Stack (most recent call first):
  cmake/toolchains/Toolchain-arm-none-eabi.cmake:31 (cmake_force_c_compiler)
  build_px4fmu-v3_default/CMakeFiles/3.6.3/CMakeSystem.cmake:6 (include)
  CMakeLists.txt:275 (project)

CMake Deprecation Warning at /Users/aditya/anaconda/share/cmake-3.6/Modules/CMakeForceCompiler.cmake:93 (message):
  The CMAKE_FORCE_CXX_COMPILER macro is deprecated.  Instead just set
  CMAKE_CXX_COMPILER and allow CMake to identify the compiler.
Call Stack (most recent call first):
  cmake/toolchains/Toolchain-arm-none-eabi.cmake:37 (cmake_force_cxx_compiler)
  build_px4fmu-v3_default/CMakeFiles/3.6.3/CMakeSystem.cmake:6 (include)
  CMakeLists.txt:275 (project)

-- The ASM compiler identification is GNU
-- Found assembler: /usr/local/bin/arm-none-eabi-gcc
-- Found PythonInterp: /Users/aditya/anaconda/bin/python (found version "2.7.13") 
-- Found PY_jinja2: /Users/aditya/anaconda/lib/python2.7/site-packages/jinja2  
-- C compiler: arm-none-eabi-gcc (GNU Tools for ARM Embedded Processors) 5.4.1 20160919 (release) [ARM/embedded-5-branch revision 240496]
-- C++ compiler: arm-none-eabi-g++ (GNU Tools for ARM Embedded Processors) 5.4.1 20160919 (release) [ARM/embedded-5-branch revision 240496]
CMake Error at CMakeLists.txt:447 (add_subdirectory):
  add_subdirectory given source "src/drivers/boards/px4fmu-v2" which is not
  an existing directory.

CMake Error at CMakeLists.txt:447 (add_subdirectory):
  add_subdirectory given source "src/drivers/snapdragon_rc_pwm" which is not
  an existing directory.

-- Using C++03
-- Release build type: MinSizeRel
-- Adding UAVCAN STM32 platform driver
CMake Error at CMakeLists.txt:447 (add_subdirectory):
  add_subdirectory given source "src/modules/camera_feedback" which is not an
  existing directory.

CMake Error at cmake/nuttx/px4_impl_nuttx.cmake:208 (get_target_property):
  get_target_property() called with non-existent target
  "drivers__boards__px4fmu-v2".
Call Stack (most recent call first):
  src/firmware/nuttx/CMakeLists.txt:4 (px4_nuttx_generate_builtin_commands)

CMake Error at cmake/nuttx/px4_impl_nuttx.cmake:208 (get_target_property):
  get_target_property() called with non-existent target
  "drivers__boards__px4fmu-v2".
Call Stack (most recent call first):
  src/firmware/nuttx/CMakeLists.txt:4 (px4_nuttx_generate_builtin_commands)

CMake Error at cmake/nuttx/px4_impl_nuttx.cmake:208 (get_target_property):
  get_target_property() called with non-existent target
  "drivers__boards__px4fmu-v2".
Call Stack (most recent call first):
  src/firmware/nuttx/CMakeLists.txt:4 (px4_nuttx_generate_builtin_commands)

CMake Error at cmake/nuttx/px4_impl_nuttx.cmake:208 (get_target_property):
  get_target_property() called with non-existent target
  "drivers__snapdragon_rc_pwm".
Call Stack (most recent call first):
  src/firmware/nuttx/CMakeLists.txt:4 (px4_nuttx_generate_builtin_commands)

CMake Error at cmake/nuttx/px4_impl_nuttx.cmake:208 (get_target_property):
  get_target_property() called with non-existent target
  "drivers__snapdragon_rc_pwm".
Call Stack (most recent call first):
  src/firmware/nuttx/CMakeLists.txt:4 (px4_nuttx_generate_builtin_commands)

CMake Error at cmake/nuttx/px4_impl_nuttx.cmake:208 (get_target_property):
  get_target_property() called with non-existent target
  "drivers__snapdragon_rc_pwm".
Call Stack (most recent call first):
  src/firmware/nuttx/CMakeLists.txt:4 (px4_nuttx_generate_builtin_commands)

CMake Error at cmake/nuttx/px4_impl_nuttx.cmake:208 (get_target_property):
  get_target_property() called with non-existent target
  "modules__camera_feedback".
Call Stack (most recent call first):
  src/firmware/nuttx/CMakeLists.txt:4 (px4_nuttx_generate_builtin_commands)

CMake Error at cmake/nuttx/px4_impl_nuttx.cmake:208 (get_target_property):
  get_target_property() called with non-existent target
  "modules__camera_feedback".
Call Stack (most recent call first):
  src/firmware/nuttx/CMakeLists.txt:4 (px4_nuttx_generate_builtin_commands)

CMake Error at cmake/nuttx/px4_impl_nuttx.cmake:208 (get_target_property):
  get_target_property() called with non-existent target
  "modules__camera_feedback".
Call Stack (most recent call first):
  src/firmware/nuttx/CMakeLists.txt:4 (px4_nuttx_generate_builtin_commands)

-- Adding ROMFS on px4fmu-v3
-- Nuttx build for px4fmu-v3 on m3 hardware, using nsh 
-- Configuring incomplete, errors occurred!
See also "/Users/aditya/Documents/GX_error/build_px4fmu-v3_default/CMakeFiles/CMakeOutput.log".
/bin/sh: line 0: cd: /Users/aditya/Documents/GX_error/build_px4fmu-v3_default: No such file or directory
make: *** [px4fmu-v3_default] Error 1

aditya00j commented 6 years ago

Also, you seem to have removed the simulator module. That is an essential module which needs to be retained.

aditya00j commented 6 years ago

For make posix_sitl_default, I am getting an error in src/systemcmds/tests/tests_main.h, line 97. This has a reference to mc_pos_control that needs to be removed.

aditya00j commented 6 years ago

Hi, I went through the entire structure, and have the following comments:

You can remove the dataman module. I took a full look at what it does - it stores the mission waypoints in persistent memory. We will have to do it through Matlab, and at this point I don't think we can use dataman for it. We'll have to come up with our own mechanism for it. I hope this will take care of your earlier issue, if you just remove the module.

You can also remove the following modules, which are still existing in your branch, and which we don't need:

src/systemcmds/motor_ramp
src/systemcmds/motor_test
src/systemcmds/sd_bench
src/systemcmds/tests
src/systemcmds/usb_connected
src/modules/unit_test
src/examples (remove the entire folder if possible)
src/lib/launchdetection
src/lib/runway_takeoff
src/lib/tailsitter_recovery
src/lib/terrain_estimation

Also remove the Documentation folder (I think it can be simply deleted), since we have already moved all that documentation to our central documentation repository.

bluetulip89 commented 6 years ago

Ok we will make all the necessary changes and update

bluetulip89 commented 6 years ago

I uploaded the uncleaned version, we have the cleaned version with us. We will cross check the necessary changes of dataman and reupload it.

aditya00j commented 6 years ago

You can send me the cleaned version as either a zip file or a Google Drive upload. I will upload it as a separate GitHub repository, that should take care of the errors you were getting. Let us try to finish the mods by today or tomorrow, so that we can do the testing this weekend. We can close the project by early next week.

priyablue commented 6 years ago

Having smaller issues in jmavsim,sitl_gazebo removal (submodule git removal) . Will upload the clean build in within afternoon.

And is the package came_hexagon has to be retained after git removal?

aditya00j commented 6 years ago

Ok. cmake_hexagon has to do with Snapdragon processor, so it can be removed.

priyablue commented 6 years ago

Ok , is the folder src/drivers/sf0x or src/drivers/sf0x_tests is needed?

priyablue commented 6 years ago

For the sake of hardware testing (seeing the uorb messages in console) , the px4_simple_app in examples folder has been retained. all the other has been removed. as advised

aditya00j commented 6 years ago

Ok, that is fine. I was also going to add some apps for testing anyways, so its better to keep one app.

priyablue commented 6 years ago

comment on this .

Ok , is the folder src/drivers/sf0x or src/drivers/sf0x_tests is needed?

aditya00j commented 6 years ago

It's a rangefinder device. We should keep it, in case we decide to use it. Is there any problem with keeping it?

priyablue commented 6 years ago

lastly " unit_test " is creating huge impact on mavlink. Is this folder can be retained? else almost all functions in mavlink_tests will become unused. So let me know whether this folder mavlink_tests can be retained or removed along with unit_tests

priyablue commented 6 years ago

yes creating problem with mavlink. sf0x is ok ... sf0x_tests is the one creating problem during compile as it depending on unit_tests

aditya00j commented 6 years ago

unit_tests defines a class called UnitTest, which is used by many other modules to define unit tests. Therefore we can't delete unit_tests module, since it will impact many other modules. Can you post the error you are getting with unit_tests? Most probably, the error is being created somewhere else which is only using unit_tests module.

aditya00j commented 6 years ago

Please let me know if you are encountering any other errors. If possible, I would like to do most of the testing this weekend.

aditya00j commented 6 years ago

Hi, will you be able to give me the updated code tomorrow? We are far too behind on schedule, I need to finish the testing asap.

aditya00j / GX

Need advise on resolving error in dataman module #19