search

aditya109 / git-osp-for-beginners

A GitHub Repository to encourage and involve beginners in Open Source Contributions
GNU General Public License v3.0
104 stars 250 forks source link

Sum of Distance in Tree #535

Closed cxj51693 closed 2 years ago

cxj51693 commented 2 years ago

Suppose there is a tree with N nodes labelled from 0to n-1 We have to return an array of length n where there is sum of each and every branch from root to leaf.

pranjalg13 commented 2 years ago

Hey @cxj51693 can I take this up?

cxj51693 commented 2 years ago

No I'm on it already. Sorry @pranjalg13

aditya109 commented 2 years ago

Hi @cxj51693 ! Sure thing. I have assigned this issue to you. Before raising a PR, please take a look at CONTRIBUTING.md and follow the guidelines. Also, if it is not too much to ask, please consider starring ⭐ the repository. It helps boost the repo popularity and guide more people towards active contribution. That is all. Happy hacking !

aditya109 commented 2 years ago

Hey @cxj51693 can I take this up?

Hi @pranjalg13 ! You can also raise a PR for this issue. Just follow CONTRIBUTING.md and raise your changes in the PR. Happy hacking !

pranjalg13 commented 2 years ago

Hey @aditya109 there are issues with the code pushed by @cxj51693 . There is no main method, the signature of public method is not same as file name. Please check this once.

aditya109 commented 2 years ago

Hey @aditya109 there are issues with the code pushed by @cxj51693 . There is no main method, the signature of public method is not same as file name. Please check this once.

Hey @pranjalg13 ! You are right ! CI pipelines must have auto-injected main while testing the program. If you wish to raise a correction, please go ahead.

pranjalg13 commented 2 years ago

Hey @aditya109 check the PR once. Updated main method with solution structure.

aditya109 commented 2 years ago

This issue was solved by @pranjalg13 @cxj51693 , the PRs were successfully merged ! Thereby, closing this issue !