Add bin tree height riddle ( #87 )

adityaarakeri / Interview-solved

🌴 Solutions to few of the interview coding challenges in Python 🐍

MIT License

40 stars 62 forks source link

Add bin tree height riddle ( #87 ) #88

Closed sharpblade4 closed 3 years ago

sharpblade4 commented 3 years ago

IMPORTANT: Please do not create a Pull Request without an issue.

closes #87

All Submissions:

[x] I have read the CONTRIBUTING document.
[x] My code is written in Python3 and is ending with .py
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] I have checked that my submission does pass the test on LeetCode.com [irrelevant]
[x] Does your filename follow the naming Conventions?
[x] Have you linked your PR to an Issue?

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

sharpblade4 commented 3 years ago

@adityaarakeri any idea why I'm failing the CI? (it seems that the build fails on unrelated component, something that I didn't change)

EDIT: I found an error in my code and fixed it. However due to the randomness of collecting test/test_shuffle_music_playlist.py sometimes the build will fail and sometimes it won't (there's a bug in that code, unrelated to my contribution).

EDIT2: I fixed the non-related code so that future PRs will not encounter this.

sharpblade4 commented 3 years ago

Could you please rename your folder with out spaces

@adityaarakeri I didn't make this folder, it already has older code in it. I was just sticking to the current structure.

Note that I already fixed a bug in the repository (unrelated to my contribution) and I want to avoid spending more time on minor global-repo issues.

EDIT: nvm, I just did it..

adityaarakeri commented 3 years ago

Could you please rename your folder with out spaces

@adityaarakeri I didn't make this folder, it already has older code in it. I was just sticking to the current structure.

Note that I already fixed a bug in the repository (unrelated to my contribution) and I want to avoid spending more time on minor global-repo issues.

EDIT: nvm, I just did it..

Thanks @sharpblade4