adityab / CrossQ

Official code release for "CrossQ: Batch Normalization in Deep Reinforcement Learning for Greater Sample Efficiency and Simplicity"
http://aditya.bhatts.org/CrossQ
Other
54 stars 3 forks source link

Improvement in default args #4

Closed JankowskiChristopher closed 5 months ago

JankowskiChristopher commented 5 months ago

Hello, I have a tiny suggestion to improve the code. In train.py, the current default algo is SAC, which is a little bit counter intuitive for the CrossQ repository. My suggestion is to change it to crossq in case user forgets to change it when running.

Suggested change:

parser.add_argument("--algo", type=str, required=False, default='crossq', choices=['crossq', 'sac', 'redq', 'droq', 'td3'], help="agent to run")

side note: currently in help there is a typo - "critic activation function" instead of help related to choosing the agent.

adityab commented 5 months ago

Just pushed the following

Thanks for the pointers!