adityabisoi / github-rest-api-v3

GitHub REST API playground

GNU General Public License v3.0

11 stars 20 forks source link

Implement and enhance UI #25

Closed paramsiddharth closed 3 years ago

paramsiddharth commented 3 years ago

Related Issue

Closes #5: Enhance UI

Proposed Changes

Separation of concerns: Move business logic, components, and controls out of App.js and import them as needed.
Create GitHub-like UI using Reactstrap, a Bootstrap extension library made specifically for React. The UI is responsive i. e. Is optimized for all screen-sizes.
Scaffold a component for visualization and bind API data. This would allow other participants to start working on the visualizations.

Additional Info

The UI inside <App/> is distributed into 3 parts, <Header/>, <Main/>, and <Footer/>.
The GitHub API handling logic is now in services/GitHub.js.
<Visualization data={info} /> has props.data bound to the output of API calls done by GitHub.js. console.log(data); may simply be removed in future versions.

Checklist

[ ] Tests
[ ] Translations
[ ] Documentation

Screenshots

Original	Updated

adityabisoi commented 3 years ago

@paramsiddharth It's always a better option to create a new branch for each issue you resolve. This keeps workflow clean.

paramsiddharth commented 3 years ago

@paramsiddharth It's always a better option to create a new branch for each issue you resolve. This keeps workflow clean.

Noted! I'll take care of that next time.