adityabisoi / github-rest-api-v3

GitHub REST API playground
GNU General Public License v3.0
11 stars 20 forks source link

[Fixes #6] Added github star and fork buttons #34

Closed Vrindagupta6828 closed 3 years ago

Vrindagupta6828 commented 3 years ago

Related Issue

Proposed Changes

Checklist

Screenshots

Original Updated

new | old

adityabisoi commented 3 years ago

@Vrindagupta6828 update with the new changes.

Vrindagupta6828 commented 3 years ago

@adityabisoi what are the new changes?

adityabisoi commented 3 years ago

There's a header added. Place the buttons on the header on the left side of Compare users button.

Vrindagupta6828 commented 3 years ago

Capture @adityabisoi Will this work? If yes please merge my pr

Vrindagupta6828 commented 3 years ago

@adityabisoi Do i have to do anything else?

adityabisoi commented 3 years ago

@Vrindagupta6828 As I said, You have added the buttons on an empty page where there is no header.

Suggestion: Delete this PR and your local branch. Checkout to main, pull latest changes. Add the same two lines for buttons just beside Compare Users in header.js and checkout to a new branch, and finally push it.

Vrindagupta6828 commented 3 years ago

@adityabisoi I added it just before the compare users button but still they are not coming beside compare users

Vrindagupta6828 commented 3 years ago

can you suggest anything?

adityabisoi commented 3 years ago

@Vrindagupta6828 I just suggested you above. That is the most detailed solution I could provide

Vrindagupta6828 commented 3 years ago

@adityabisoi I have added in the navbar header

adityabisoi commented 3 years ago

Closing this PR. Please take up a different one.

Vrindagupta6828 commented 3 years ago

@adityabisoi I have been working on it since a long time atleast give me one more chance