adityadash03 / PCFTwoOptionBooleanButton

Two Option Button
GNU General Public License v3.0
1 stars 0 forks source link

Allow inversion of button order #4

Open bwmodular opened 1 year ago

bwmodular commented 1 year ago

There are times when you might want the options to be displayed as 1 then 0, rather than 0 then 1. Here's an example with Out of the Box fields on the Account entity: image

Because Microsoft have been inconsistent with the way they have configured these fields (Allow = 0 except for Follow Email where Allow = 1), the controls are rendered inconsistently with Allow sometimes on the right and sometimes on the left. An 'Invert' option would allow for the options to be rendered the other way round.

adityadash03 commented 1 year ago

It reads the two options and set in order o and 1. Control reads text from two option and doesn’t compare the text values to set.

Not an issue.

On Wed, Jun 28, 2023 at 5:27 AM Ben Walker @.***> wrote:

There are times when you might want the options to be displayed as 1 then 0, rather than 0 then 1. Here's an example with Out of the Box fields on the Account entity: [image: image] https://user-images.githubusercontent.com/1889586/249419114-d3d0db50-3d13-4aad-ab85-7a411d1cc091.png

Because Microsoft have been inconsistent with the way they have configured these fields (Allow = 0 except for Follow Email where Allow = 1), the controls are rendered inconsistently with Allow sometimes on the right and sometimes on the left. An 'Invert' option would allow for the options to be rendered the other way round.

— Reply to this email directly, view it on GitHub https://github.com/adityadash03/PCFTwoOptionBooleanButton/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQUVQUYYDGFQCEL644L5G4LXNP2ILANCNFSM6AAAAAAZWYMZSE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

bwmodular commented 1 year ago

Hi there, thanks for the explanation. I don't think it's a bug, but its a request for an improvement.

Look at these two out of the box fields on the Account entity. Here's the 'DoNotEmail' fields Yes/No settings: image and here's the settings for the 'FollowEmail' field. image

Because Microsoft have configured these fields in the opposite way to each other, when they render with your control, sometimes Allow is on the Right and sometimes on the Left, which is a very poor experience from the user point of view.

So if you could add an option to allow to invert the order in which the options are displayed, we could make this look nicer for the user. Alternatively, you could display the values in the order set by the user here: image