adityapk00 / zecwallet-lite

Zecwallet-Lite is z-Addr first lightwallet for Zcash.
MIT License
106 stars 83 forks source link

Certain emoji disables the reply function #212

Open autotunafish opened 1 year ago

autotunafish commented 1 year ago

Describe the bug A utf-8 shield icon 🛡 of the hex sequence f09f9ba1 placed anywhere in the memo will disable the reply function.

To Reproduce 1 Create a transaction in any shielded wallet with a memo containing only a return address in a suitable location. The Regex splits at /[ :\n\r\t]+/ and the address may be the only text present. 2 Place a shield icon containing the hex code above anywhere in the memo that it would not otherwise affect the Regex match and address verification. 3 Send to a Zecwallet Lite desktop and attempt the reply button.

Expected behavior The Regex matches in the same manner as using the "Reply-To" or any other non-regex-matchable prefix that satisifies. The icon at the beginning, followed by a newline, followed by the addy should work.

Desktop (please complete the following information):

Additional context It also appears that memo prefixes of certain lengths also disable the reply function. For example :smile:MSG(newline) doesn't work (16 hex chars f09f98804d53470a) but :smile:MS(newline) does (14 hex chars f09f98804d530a).