on macOS Sonoma and Safari `defaultTheme = auto` does not appear to work properly

adityatelange / hugo-PaperMod

A fast, clean, responsive Hugo theme.

https://adityatelange.github.io/hugo-PaperMod/

MIT License

9.6k stars 2.59k forks source link

on macOS Sonoma and Safari `defaultTheme = auto` does not appear to work properly #1382

Closed nicolaiarocci closed 8 months ago

nicolaiarocci commented 8 months ago

macOS Sonoma with Dark Mode set on 'auto' (or 'dark').
config.yml defaultTheme set to 'auto';.
On Chrome, website correctly appears as dark, matching the SO setting.
On Safari, website stays 'light', while it should be dark.

Os: macOS Sonome 14.1.1
Type: Desktop
Browser and version Safari 17.1
Hugo Version 0.121.1
Theme Version: master

chrisrummel commented 8 months ago

Can't confirm that. I have both Sonoma's theme on auto and my website on auto and when using Safari my website is displayed with the light theme at daytime and with the dark theme at nighttime.

Edit: Thinking about it... I usually don't care for my website being displayed in dark or light so I don't change it, but I do get it displayed in Safari in both ways without ever switching it. But afaik the theme toggle is meant to be persistent, meaning users choose the theme and it stays that way. I am not really sure why I get a light theme sometimes and a dark theme some other times.

nicolaiarocci commented 8 months ago

As per @chrisrummel hint I deleted my website cookies, refreshed the page, and now it appears dark as it should given that we're in the evening in my timezone. So it appears that if a visitor opts for dark/light via the UI button, that preference will be saved for his/her next visits, which is probably a nice feature to have.