adityatelange / hugo-PaperMod

A fast, clean, responsive Hugo theme.
https://adityatelange.github.io/hugo-PaperMod/
MIT License
9.9k stars 2.69k forks source link

Add demosite for "Demo" button on themes.gohugo.io #1412

Closed leoheitmannruiz closed 9 months ago

leoheitmannruiz commented 9 months ago

What does this PR change? What problem does it solve?

At https://themes.gohugo.io/themes/hugo-papermod/ there is no direct link to the demo site. This PR adds the demosite variable (idk what its called) in theme.toml, which is necessary for the "Demo" button. See https://github.com/gohugoio/hugoThemesSiteBuilder#theme-configuration.

PR Checklist

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

adityatelange commented 9 months ago

Not required. thanks 👍

leoheitmannruiz commented 9 months ago

Why? It seems very convenient to know how to visit the demo site across themes on themes.gohugo.io, not having to skim each README for a link.

adityatelange commented 9 months ago

Why? It seems very convenient to know how to visit the demo site across themes on themes.gohugo.io, not having to skim each README for a link.

ya it's tiring i know right. 8k people have done it already. thanks to them.

leoheitmannruiz commented 9 months ago

I'm not sure I get your point. Do you not think that adding the "Demo" button increases user experience, if ever so slightly?

If a lot of complexity was necessary to do so, I'd wouldn't be interested either. This is however a single key-value pair, intended to be set.