adityatelange / hugo-PaperMod

A fast, clean, responsive Hugo theme.
https://adityatelange.github.io/hugo-PaperMod/
MIT License
9.53k stars 2.58k forks source link

add buttondown logo #1419

Closed nicolaiarocci closed 6 months ago

nicolaiarocci commented 7 months ago

What does this PR change? What problem does it solve?

Add buttondown (https://buttondown.email) icon.

image image

PR Checklist

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

zacharyc commented 7 months ago

Should you add this to the documentation as well?

nicolaiarocci commented 7 months ago

@zacharyc you mean the wiki? To my knowledge GitHub doesn't support pull requests to the wiki repo. I already cloned and updated it locally, but I see no way to contribute it back.

zacharyc commented 7 months ago

@nicolaiarocci you are right, tried the same thing, sorry.

nicolaiarocci commented 6 months ago

@adityatelange I can do that. However, a few weeks ago I got in touch with the buttondown service author over email asking for permission, and he said that in his opinion the original logo appears too "bold" compared to the others:

image image

He kindly offered to make a custom one for PaperMod, and his custom svg is the one submitted with this PR. If you still want to original, I will update the pull request of course.

adityatelange commented 6 months ago

@adityatelange I can do that. However, a few weeks ago I got in touch with the buttondown service author over email asking for permission, and he said that in his opinion the original logo appears too "bold" compared to the others:

image image He kindly offered to make a custom one for PaperMod, and his custom svg is the one submitted with this PR. If you still want to original, I will update the pull request of course.

I appreciate his efforts to make a custom one for PaperMod. If the owner prefers it this way sure, I will merge it.