search

adityatelange / hugo-PaperMod

A fast, clean, responsive Hugo theme.
https://adityatelange.github.io/hugo-PaperMod/
MIT License
9.72k stars 2.62k forks source link

[BUG] Relative image paths are not handled properly in pages of secondary languages #1496

Open yoching opened 5 months ago

yoching commented 5 months ago

Describe the bug

Steps to reproduce the behavior:

  1. On exampleSite branch of this repo, in content/posts/papermod/papermod-featuresdirectory, duplicate index.md and name it index.fa.md or index.fr.md
  2. Run hugo server from terminal
  3. Open the page (http://localhost:1313/hugo-PaperMod/posts/papermod/papermod-features/), check all the images are displayed
  4. Open the same page in other languages. http://localhost:1313/hugo-PaperMod/fr/posts/papermod/papermod-features/ or http://localhost:1313/hugo-PaperMod/fa/posts/papermod/papermod-features/ (You can also click Translations : 🇫🇷 or Fa under the post title.)
  5. Images in Regular Mode (default-mode) and Home-Info Mode sections are not shown

Expected behavior: The images should appear regardless of languages. (This used to work before. I'm not sure from which version this behavior was changed.)

Repo/Source where this issue can be reproduced:

I updated the example-site and pushed to forked repo here. https://github.com/yoching/hugo-PaperMod/tree/exampleSite-image-language (But it's only duplicating index.md. No content change)

Screenshots

Additional context

I first realized that images are not shown on my website, which has English and Japanese pages. I was able to reproduce it with the example site of this repository. Until about half a year ago (I can't remember exactly), the images appeared without problem.

adityatelange commented 5 months ago

Hi @yoching hope you are setting proper baseURL for each language.

https://gohugo.io/content-management/multilingual/#configure-multilingual-multihost

yoching commented 5 months ago

In the hugo-PaperMod example site, base URLs are not set for each language, and root URLs for each language are these:

I tried setting these as the baseURL for each language. However, with the setting, now common assets (e.g. css) are not handled properly, then FR or FA sites become broken (no CSS).

Are there any ways to avoid this?

adityatelange commented 5 months ago

@yoching do you think this might be related? https://github.com/gohugoio/hugo/issues/8109

yoching commented 5 months ago

@adityatelange No, adding absLangURL doesn't solve the stylesheet issue.

I'm not sure if adding baseURL is a good idea in this case, as multiple language sites are configured on these endpoints:

EN: https://adityatelange.github.io/hugo-PaperMod/ FR: https://adityatelange.github.io/hugo-PaperMod/fr/ FA: https://adityatelange.github.io/hugo-PaperMod/fa/

adityatelange commented 4 months ago

@yoching looks like this issue is related to #1504