Update he.yaml - Githubissues

adityatelange / hugo-PaperMod

A fast, clean, responsive Hugo theme.

https://adityatelange.github.io/hugo-PaperMod/

MIT License

10.26k stars 2.72k forks source link

Update he.yaml #1594

Closed idanhazan closed 1 week ago

idanhazan commented 2 months ago

PR Summary:

This PR includes three types of changes:

Completion of Missing Translations: Added translations for previously missing content.
Content Corrections: Corrected translations to better reflect the intended meaning.
Language Direction Adjustments (RTL): Fixed issues related to the right-to-left (RTL) text direction to ensure proper display and readability.

Please review the changes and let me know if there are any additional adjustments needed. Thank you!

adityatelange commented 2 months ago

@eisraeli @RealA10N requesting your review

idanhazan commented 2 months ago

I had two additional questions:

Should we use "דקה 1" instead of "דקה אחת" to maintain consistency with the English version, which uses "1 min" rather than "one min"?
Should we use "מילה 1" or "מילה אחת" instead of just "מילה" to align with the format used for minutes?

In terms of correct Hebrew, it is preferable to use the phrases: "דקה אחת" and "מילה אחת"

RealA10N commented 2 months ago

IMO there is no need to enforce consistency across languages at this micro level: as long as the meaning is consistent, the exact wording should be in accordance with the laws of the local language.

So I suggest:

מילה אחת

For "1 word", and,

דקה אחת

For "1 min".

Other than that, LGTM!

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud