:bug: Fix menu localization: site.Menus URLs are already localized

[npellegrin]

What does this PR change? What problem does it solve?

It appears that a website having a custom base URL generate invalid menu links using this template. The reason is a computation of localization using absLangURL over site.Menus -> .URL items.

In recent versions of Hugo, the site.Menus items are already localized. You can see in the official example here, there is no absLangURL declared after .URL: https://gohugo.io/templates/menu/#example

absLangURL should be used to convert a relative URL to a localized URL in case the URL is not localized yet. Calling a already-localized URL with absLangURL will append the language code twice. The problem may be not visible without declaring a custom baseURL because Hugo seems to automatically strip duplicated localization codes for ease.

Was the change discussed in an issue or in the Discussions before?

I have not seen any issue about that, feel free to point it out if I missed it.

PR Checklist

• [ ] This change adds/updates translations and I have used the template present here.
• [x] I have enabled maintainer edits for this PR.
• [x] I have verified that the code works as described/as intended.
• [ ] This change adds a Social Icon which has a permissive license to use it.
• [x] This change does not include any CDN resources/links.
• [x] This change does not include any unrelated scripts such as bash and python scripts.
• [ ] This change updates the overridden internal templates from HUGO's repository.

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud