adityathakurxd / university

Open Source app to view Free resources available online.
Apache License 2.0
24 stars 26 forks source link

[SCREEN] Onboarding screen #6

Closed adityathakurxd closed 3 years ago

adityathakurxd commented 3 years ago

TODO

Create an onboarding.dart in the screens folder. The would have 3 graphic images, 3 descriptive texts about the app, and 2 sign-in buttons.

Design

Untitled-2021-09-09-1008

Note

Please use only the null safe package for Swiper.

Samdid commented 3 years ago

I would like to work on this issue

adityathakurxd commented 3 years ago

Hey @Samdid, Please go ahead.

You'll only need to do the frontend side of things which means:

Note: Make sure the swiper package you use is null safe. For the images or icons, feel free to use any as per your discretion. Make sure they are open for use. For now, set the onPressed of the buttons to the empty HomeScreen widget.

If you have any questions, feel free to tag me here or on Discord (Link: https://teamaditya.co/)

Samdid commented 3 years ago

Okay sir! Is this repo came under Hactoberfest'21

adityathakurxd commented 3 years ago

Yes! I had added the Hacktoberfest topic to the repo and followed the steps listed on their website.

Samdid commented 3 years ago

Okay then my contribution is to be included in the hactoberfest'21 right?

adityathakurxd commented 3 years ago

Hey if you're only doing it for a Free T-shirt I'd recommend you to not do it.

The repository is made for community contribution for people looking to start with Open Source. The issue had been labelled lvl1 and not marked with Hacktoberfest label until October.

Samdid commented 3 years ago

Yeah exactly, I am also asking about the same. If the month of October has not started then the contribution phase may not have started so I had to confirm so I asked. And the main thing to say is, I don't think that the Hactoberfest is all about just a T-shirt. It's a mega event for open source contributors. And I heard a lot about this so I was excited to contribute in this. But I didn't know some people like you contributed here for just a T-shirt. Let it be, I am a contributor here and I'll do my work. And you are the maintainer of this repo who forget to add the label of hactoberfest and all this occurs. And I don't think, just clearing my doubt take you to unassigning the issue.

adityathakurxd commented 3 years ago

Alright if you still stand by the I am a contributor here and I'll do my work, why don't you go ahead and contribute instead of pestering over if your contribution is to be included in the hactoberfest'21 or not :)

adityathakurxd commented 3 years ago

Here, added back the assign! Whenever you're ready. 🙌 Let me know if you need any help.

Samdid commented 3 years ago

Yeah sure👍

Samdid commented 3 years ago

Hey @adityathakurxd , I tried so much to find google-services.json file but didn't get. I think, it is not there in the repo. Can you please add that file? Or if it is there then please give me it's location. Because I can't run this project without that file.

adityathakurxd commented 3 years ago

I had added the json to gitignore. I was thinking of not having it public. So, I removed Firebase initialization from main in latest commit. Is it still causing error?

adityathakurxd commented 3 years ago

While the UI changes are being done, it should not have Firebase added. Let me try running it without and get back to you! Sorry for the inconvenience.

Samdid commented 3 years ago

Yeah, it's okay!

adityathakurxd commented 3 years ago

I tried running it without the JSON and it is working fine. What you can do is:

or, you can replace the main.dart code with this:

import 'package:flutter/material.dart';
import 'package:university/screens/auth/sign_in_screen.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: SignInScreen(),
    );
  }
}

It removes the firebase initialization and fixes the issue!

adityathakurxd commented 3 years ago

Also, let me know if it is running without on your system. I'll add it then if it doesn't.

adityathakurxd commented 3 years ago

Hey @Samdid, I have added the .json to the repository in the latest merge #15

Samdid commented 3 years ago

Oh okay, I'll check

Samdid commented 3 years ago

Hey @adityathakurxd, it's working