[x] Function to generate the waveform for unevenly space frequency array (This should be pretty easy; basically one needs to define a _base waveform in source.py and use lalsim_SimInspiralChooseFDWaveformSequence instead of lalsim_SimInspiralChooseFDWaveform)
[x] Add new frequency_domain_source_model in source.py. This source model should return the fiducial waveform (and the summary data) using the full frequency array and the likelihood calculation waveforms using the binned array.
[x] Makes changes to compute_relative_ratio
[x] For summary data calculation (in compute_as_and_bs), use noise_weighted_inner_product
[x] Remove num_points from setup_bins.
[x] Issues with zeros of the waveform (this is probably occuring in cases where the waveform is getting terminated before fmax)
[x] The calculation is being done only for parameter_dictionary and not for self.parameters. Correct this. (#4 - @Kruthi24)
[x] Fix and check get_detector_response_relative_binning
Things to Fix:
[x] Function to generate the waveform for unevenly space frequency array (This should be pretty easy; basically one needs to define a
_basewaveform insource.pyand uselalsim_SimInspiralChooseFDWaveformSequenceinstead oflalsim_SimInspiralChooseFDWaveform)[x] Add new
frequency_domain_source_modelinsource.py. This source model should return the fiducial waveform (and the summary data) using the full frequency array and the likelihood calculation waveforms using the binned array.[x] Makes changes to
compute_relative_ratio[x] For summary data calculation (in
compute_as_and_bs), usenoise_weighted_inner_product[x] Remove
num_pointsfromsetup_bins.[x] Issues with zeros of the waveform (this is probably occuring in cases where the waveform is getting terminated before fmax)
[x] The calculation is being done only for
parameter_dictionaryand not forself.parameters. Correct this. (#4 - @Kruthi24)[x] Fix and check
get_detector_response_relative_binning[x] Remove
log_likelihood_ratio_approx(#5 - @Kruthi24)[x] Implement scipy maximization (@Kruthi24)
[x] See if new
summary_datadictionary is the right choice.[ ] Add unit tests.
[x] Implement time, distance and phase marginalization.
[x] Remove all
printstatements and replace withloggerinstances. Also remove all instances ofsys.[ ] Write documentation
[x] Clean up comments
[x] Remove imports of
matplotlib...and more to be added in due time.