Fixed the #bins error factor

adivijaykumar / bilby

MIT License

0 stars 2 forks source link

Fixed the #bins error factor #13

Closed Kruthi24 closed 3 years ago

Kruthi24 commented 3 years ago

I have made modifications to the compute_summary_data function to return a bin dependent summary data.

adivijaykumar commented 3 years ago

That is great news! I am not sure I understand the explanation you provided on slack, but I might when I am not sleepy tomorrow morning. Have you checked if the likelihood calculation is now consistent?

Kruthi24 commented 3 years ago

Yup. They match up to the second decimal.

adivijaykumar commented 3 years ago

Also, fdecb57 had a lot of code-style issues. Don't you have the pre-commit checks configured as per development instructions? I suggest you do this if you haven't.

Anyway, I have fixed the issues in 21f8326 using autopep8.

Kruthi24 commented 3 years ago

Nope. I need to figure that out.