search

adivijaykumar / bilby

MIT License
0 stars 2 forks source link

Add frequency masks in get_detector_response_relative_binning #17

Closed Kruthi24 closed 3 years ago

adivijaykumar commented 3 years ago

First question: Did you do a consistency check with init_params?

Also, the new changes in relbin have not been pulled to relbin_kruthi, so please pull them before you run a test.

Kruthi24 commented 3 years ago

Yup. I basically cross-checked the output of get_detector_response_relative_binningwith the output of get_detector_response. I also ran the bilby_likelihood_error.py script for different epsilon values.

Have there been any new changes to relbin since last night?

adivijaykumar commented 3 years ago

No, but the commit history is different for the branches. Hence asked.

Kruthi24 commented 3 years ago

Fixed it.

adivijaykumar commented 3 years ago

Did you run the tests also?

Kruthi24 commented 3 years ago

Yup. I basically cross-checked the output of get_detector_response_relative_binningwith the output of get_detector_response. I also ran the bilby_likelihood_error.py script for different epsilon values.

Just these.

adivijaykumar commented 3 years ago

Merging this PR, by noting #18.