search

adivijaykumar / bilby

MIT License
0 stars 2 forks source link

Time, phase and distance marginalization #24

Closed Kruthi24 closed 3 years ago

Kruthi24 commented 3 years ago

Please take a look at the jitter_timesettings. There's some error with that. Right now, everything works only if jitter_time is set to False in the likelihood call.

adivijaykumar commented 3 years ago

@Kruthi24 what is the status on this? There were some problems with init right which #26 didn't fix amirite? It is probably worth debugging this together on call; what do you think?

Kruthi24 commented 3 years ago

We have to fix the rescaling and jitter time.

It is probably worth debugging this together on call

Yup!

Kruthi24 commented 3 years ago

@adivijaykumar I think all the 3 marginalizations are fine now. We should launch runs to test this though.

Kruthi24 commented 3 years ago

Please review this pull request and merge it.

adivijaykumar commented 3 years ago

Can we do test runs before merging actually? It'll be better than way.