search

adivijaykumar / bilby

MIT License
0 stars 2 forks source link

WIP: Remove bottlenecks in the calculation of likelihood #33

Closed adivijaykumar closed 3 years ago

adivijaykumar commented 3 years ago

Remove stuff in get_detector_response_relative_binning which deals with masking; not required for relative binning. It is responsible for a large overhead too,

Kruthi24 commented 3 years ago

Checked the branch for

  1. Consistency between likelihoods for fiducial parameters
  2. Consistency between the strain calculated with get_detector_response_relative_binning and get_detector_responsematched at the bin edges
  3. Consistency between likelihoods for parameters different from fiducial ones
  4. issues while sampling