search

adivijaykumar / bilby

MIT License
0 stars 2 forks source link

Removed log_likelihood_ratio_approx and also removed factor of 2 in compute_summary_data #5

Closed Kruthi24 closed 3 years ago

Kruthi24 commented 3 years ago

I have removed log_likelihood_ratio_approx. And the scipy maximization is not yet working.

Kruthi24 commented 3 years ago

We have to change conversion.py to use likelihood.calculate_snrs_from_summary_data for the case where relative binning is used, right?

adivijaykumar commented 3 years ago

We have to change conversion.py to use likelihood.calculate_snrs_from_summary_data for the case where relative binning is used, right?

Yes that's right Kruthi! I didn't have time to look into it in detail, but it there a quickfire way in which we can do this?

adivijaykumar commented 3 years ago

2a1dd91 closes #6.