search

adivijaykumar / bilby

MIT License
0 stars 2 forks source link

Error with conversion function #7

Closed Kruthi24 closed 3 years ago

Kruthi24 commented 4 years ago

We are getting the following error (screenshots attached) when we use conversion_function= bilby.gw.conversion.generate_all_bns_parameters in bilby. run_sampler. This is due to the fact that in conversion.py, likelihood.calculate_snrs is being called instead of likelihood.calculate_snrs_from_summary_data. A temporary fix for this issue has been made here #5

Screen Shot 2020-11-04 at 10 05 00 PM Screen Shot 2020-11-04 at 10 04 45 PM (1)

adivijaykumar commented 4 years ago

@Kruthi24 I think I have found a way to solve this problem --- basically one has to change the compute_snrs function inside conversion.py by adding a case with the following statement:

if isinstance(likelihood, RelativeBinningGravitationalWaveTransient):

Of course one will have to add more changes to the function, but this can be done.