adiwg / mdEditor

Web application for writing metadata, an ADIwg project
https://www.mdeditor.org
GNU General Public License v3.0
44 stars 25 forks source link

TimePeriod element titles #223

Open stansmith907 opened 6 years ago

stansmith907 commented 6 years ago

On the TimePeriod panel in the 'Main' Edit Window section I suggest ...

jlblcc commented 6 years ago
  • Changing the title 'Id' to 'ID'

Renamed to Identifier

  • Changing the title 'Fiscal Year' to 'Choose Federal Fiscal Year'

Re-styled to look like a button control

  • Also, there is no way to clear Fiscal Year

The fiscal year select now resets after selection

Screenshot
image
stansmith907 commented 5 years ago

I think we should add some consistency in naming of identifier elements. 'Id' should not be used as it is word, but 'ID' can be used as an abbreviation for identifier. Thus the change referenced above.

That much is simple. The real issue is our interchanging of 'ID' and 'Identifier'. I propose 'Identifier' is always an object referencing an externally assigned identifier. 'ID' is a locally assigned identifier which must either be unique within the metadata record (e.g. Time Period ID) or globally (e.g. Record ID).

The above TimePeriod element should then become Time Period ID.