adiwg / mdEditor

Web application for writing metadata, an ADIwg project
https://www.mdeditor.org
GNU General Public License v3.0
45 stars 25 forks source link

Taxonomy Voucher display problems #321

Open stansmith907 opened 5 years ago

stansmith907 commented 5 years ago

When adding the first voucher the species element is oversized and the initial drawing immediately redraws leaving about an inch of white space at the top of the panel. If I click 'OK' the edit panel closes. If I click 'Add' again the edit panel opens blank (empty).

Also, the voucher repository object is a responsible party but is displayed differently than everywhere else in the editor (vertical element placement rather than side-by-side. Probably should be consistent.

jlblcc commented 5 years ago

This is caused by the panel still being collapsed when trying to render the edit form. It occurs anytime the md-object-table is used and the "Add" action is called when the panel is collapsed. The edit panel tries to render immediately, since it's based on a boolean value in the template. This causes a problem since the panel body is still being "faded in". The entire md-object-table component really needs to be re-factored to make it more Ember-like and remove the dependence on the Bootstrap(jQuery) animations. I would suggest we use the ember-bootstrap addon (supports both Bootstrap 3 and 4). In the meantime, I can re-factor to make sure the panel is expanded before the edit form is rendered using the shown.bs.collapse event and an additional boolean property.

I don't think the voucher element being rendered differently is going to make a difference. I doubt anyone but a developer familiar with the metadata structure would even notice! 😄

dvonanderson commented 3 years ago

@hamaier I think this is one of the issues that Josh had previously fixed. I cannot recreate the problem stated above. I am planning on working on pieces of pushing to ember-bootstrap, in the near future. I will be sending out an updated dev version of the app, can you please try and recreate the problem there. If anything we can move the box up on the page just a touch. image

@dvonanderson