adiwg / mdEditor

Web application for writing metadata, an ADIwg project
https://www.mdeditor.org
GNU General Public License v3.0
44 stars 25 forks source link

Liability statement (liablityStatement) wrong key value written to mdJSON #497

Closed hmaier-fws closed 10 months ago

hmaier-fws commented 1 year ago

The mdEditor incorrectly writes the "liabilityStatement" to mdJSON as "liablityStatement" (missing "i"). The translator correctly imports from CSDGM and writes to JSON as liabilityStatement.

Records imported from CSDGM may contain a correctly named key, which will not be displayed in the editor. Subsequent editing of the record could result in the presence of two statements, one with the correcly spelled key and another with the incorrectly spelled key.

Tasks:

See:

I see the issue, it looks like there a misspelling, liablityStatement vs liabilityStatement (missing i)

this is coming from mdEditor https://github.com/adiwg/mdEditor/blob/f94770686df07ef76aa111f8f9734b32bbad7f21/app/pods/components/object/md-distribution/template.hbs#L22

since this is in the Production version I'll do a little digging on how we can handle upgrading existing mdJson to the correct spelling transparently in the editor, and I suppose we should handle both spellings in the translator

Originally posted by @timothypage in https://github.com/adiwg/mdTranslator/issues/236#issuecomment-1287069856

hmaier-fws commented 1 year ago

@jwaspin before PR #557 can be merged in, the logic to handle use cases 3 and 4 needs to be added otherwise users may experience data loss.

jwaspin commented 1 year ago

https://github.com/adiwg/mdTranslator/issues/236 is related