search

adiwg / mdEditor

Web application for writing metadata, an ADIwg project
https://www.mdeditor.org
GNU General Public License v3.0
44 stars 25 forks source link

Fix ITIS taxa search #503

Closed hmaier-fws closed 9 months ago

hmaier-fws commented 1 year ago

Before submitting an issue to I have first:

Issue

Issue Description:

Add taxa from ITIS search is broken.

Steps to reproduce (Bug reports only):

  1. Goto "taxonomy" menu
  2. Click "Add Collection"
  3. Click "Add Taxa from ITIS"
  4. Enter term in "Search Value" field (e.g. duck)
  5. Click "Search"

Observed Results (Bug reports only):

The problem seems to be due to reguest:

Consider updating taxonomy search to query directly from ITIS (https://www.itis.gov/). Heroku is no longer working and currently ITIS can not be queried directly due to a CORS restriction.

References:

timothypage commented 1 year ago

@hmaier-fws @dwalt I've got a potential fix for this on https://data-quality.md-editor.tzwolak.com

could you test it out when you get a chance?

dwalt commented 1 year ago

Hi Tim,

Yeah, this is working! I imported an existing record and was successful in creating and saving Data Quality to that record. Works as expected.

Unrelated, there is an error showing regarding the Record Id (Main). The edit button turns orange like it was pushed to put the id field in edit mode. Tried pushing it and confirming it, but still stays orange and in an error status.

Will need a dev translator to test translations.

Data Quality is fairly important, I would suggest moving the menu item to between Lineage and Taxonomy.

Dennis

From: Tim Zwolak @.> Sent: Thursday, January 26, 2023 7:35 AM To: adiwg/mdEditor @.> Cc: Walworth, Dennis H @.>; Mention @.> Subject: [EXTERNAL] Re: [adiwg/mdEditor] Fix ITIS taxa search (Issue #503)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

@hmaier-fwshttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhmaier-fws&data=05%7C01%7Cdwalworth%40usgs.gov%7Ca8a3e81cf9184561fe4308daffbb4813%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638103477083491158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=qsaAgY2M7aO6sSzRxkEaOvGENF6OLqT8QHezbJmVcz8%3D&reserved=0 @dwalthttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdwalt&data=05%7C01%7Cdwalworth%40usgs.gov%7Ca8a3e81cf9184561fe4308daffbb4813%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638103477083491158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fSdSd%2FZtDAXx7zHZbVDVmw9wN6kn1RcLUfeIxKHUQAs%3D&reserved=0 I've got a potential fix for this on https://data-quality.md-editor.tzwolak.comhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdata-quality.md-editor.tzwolak.com%2F&data=05%7C01%7Cdwalworth%40usgs.gov%7Ca8a3e81cf9184561fe4308daffbb4813%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638103477083491158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FAoZQ7y9Z8NcufjFISssYFvjGhSvqU86g2%2FDpIdU8Vw%3D&reserved=0

could you test it out when you get a chance?

— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadiwg%2FmdEditor%2Fissues%2F503%23issuecomment-1405278222&data=05%7C01%7Cdwalworth%40usgs.gov%7Ca8a3e81cf9184561fe4308daffbb4813%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638103477083491158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MVUmSC29UVticpGoUwybAa6om%2BC9gI%2F2MKQ9cOt63wg%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABPKCL4VI7VD3QI5QTNBY5DWUKRTPANCNFSM6AAAAAATWB3X7M&data=05%7C01%7Cdwalworth%40usgs.gov%7Ca8a3e81cf9184561fe4308daffbb4813%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638103477083491158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7vdW%2FjjaFIcRL1jH%2FKeueJO0KoMaGv82LPSRW7mclwY%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

hmaier-fws commented 1 year ago

@timothypage Data quality seems to be working but I'm still getting a CORS error for the species search:

Access to XMLHttpRequest at 'https://api.sciencebase.gov/itis-proxy?query-string-here' from origin 'https://data-quality.md-editor.tzwolak.com' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

timothypage commented 1 year ago

@hmaier-fws Hmmm, can you check settings? The mdTranslator API URL should be "https://data-quality.md-translator.tzwolak.com/api/v3/translator"

hmaier-fws commented 1 year ago

@timothypage that did it. Species seems to work.

dwalt commented 1 year ago

I set translator to those settings. HTML and sbJSON translations worked. CSDGM, -1 and -2 failed with 500 error. Still have problem with record Id. Error /metadata Should not have additional properties.

From: Tim Zwolak @.> Sent: Thursday, January 26, 2023 1:06 PM To: adiwg/mdEditor @.> Cc: Walworth, Dennis H @.>; Mention @.> Subject: [EXTERNAL] Re: [adiwg/mdEditor] Fix ITIS taxa search (Issue #503)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

@hmaier-fwshttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhmaier-fws&data=05%7C01%7Cdwalworth%40usgs.gov%7C6ea3a73f80ce4900eae108daffe9a4c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638103676205021848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=sBqvV1AM1F1m9P2%2FSN%2FUQYo%2FKKTbRwWyGRGWrT0Hxrg%3D&reserved=0 Hmmm, can you check settings? The mdTranslator API URL should be "https://data-quality.md-translator.tzwolak.com/api/v3/translatorhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdata-quality.md-translator.tzwolak.com%2Fapi%2Fv3%2Ftranslator&data=05%7C01%7Cdwalworth%40usgs.gov%7C6ea3a73f80ce4900eae108daffe9a4c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638103676205021848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=aSZH5Kt1LwV%2Bp24J7lVwLGf59MfWYN6bQ0ISwoxe4yY%3D&reserved=0"

— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadiwg%2FmdEditor%2Fissues%2F503%23issuecomment-1405733685&data=05%7C01%7Cdwalworth%40usgs.gov%7C6ea3a73f80ce4900eae108daffe9a4c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638103676205021848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=E12MD382SiqrEdbcZ2j5T9vnoEUtA%2FExPr4qD3F7iFc%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABPKCL2BZAKTZDMBY22H7P3WULYPXANCNFSM6AAAAAATWB3X7M&data=05%7C01%7Cdwalworth%40usgs.gov%7C6ea3a73f80ce4900eae108daffe9a4c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638103676205178039%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=f0EQk7QJTUjaRRfMoGhrtaQXJ0mOi3d%2BSOv2B9Ta35g%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>