Feature/Data Quality - Githubissues

adiwg / mdJson-schemas

JSON schemas, examples, and templates for ADIwg metadata standards

http://www.adiwg.org/projects/

GNU Lesser General Public License v3.0

18 stars 15 forks source link

Feature/Data Quality #262

Closed dwalt closed 8 months ago

dwalt commented 1 year ago

[ ] Missing asterisks for required elements - review schema issues
[ ] Missing element definitions - review schema issues
[ ] Order of Report elements should follow that outlined in Report schema issue #224
[ ] Evaluation Method is not an array
[ ] Quality Measure: either a name or identifier are required
[ ] Translator UI not working, network error
[ ] Type element is missing, required to identify the standard report (see issue #224)
[ ] Scope is required, max of one

jwaspin commented 1 year ago

Was PR #261 sufficient to close this?

--Update: No, PR #261 does not solve these issues

jwaspin commented 9 months ago

@dwalt

The following will be fixed in PR #269

Order of Report elements

Evaluation Method is not an array

Actually, all of the issues in the original description will be resolved in the PR, not just these 2

jwaspin commented 9 months ago

@dwalt

Translator UI not working, network error does not seem to be related to mdJson-schemas, should this be in here?

Scope is required Does this apply to everywhere scope exists within data quality? (based on them all being single objects and not an array, they are all already limited to only one, but none of the schemas indicate the scope is required)

jwaspin commented 9 months ago

What I've done: (changes exist in PR #269 )

[x] Missing asterisks for required elements - review schema issues
[x] Missing element definitions - review schema issues
[x] Order of Report elements should follow that outlined in Report schema issue #224
[x] Evaluation Method is not an array
[x] Quality Measure: either a name or identifier are required
[ ] Translator UI not working, network error
[x] Type element is missing, required to identify the standard report (see issue #224)
[x] Scope is required, max of one

jwaspin commented 8 months ago

It mentions "Translator UI not working, network error" but I'm not sure what this refers to. If I were to guess, this is actually an issue in mdTools, not mdJson-schemas, because that translator UI is not working, but there's already an issue for that in the mdTools repository.

dwalt commented 8 months ago

@jwaspin I would agree, I believe this was an artifact of previous Data Quality testing identifying that translation of DQ could not be tested.