adiwg / mdJson-schemas

JSON schemas, examples, and templates for ADIwg metadata standards

http://www.adiwg.org/projects/

GNU Lesser General Public License v3.0

18 stars 15 forks source link

Bugfix - Data Quality #269

Closed jwaspin closed 8 months ago

jwaspin commented 9 months ago

Closes #223 Closes #224 Closes #225 Closes #226 Closes #227 Closes #228 Closes #229 Closes #230 Closes #255 Closes #256 Closes #262

Changes

Incremented patch version
- package.json
- schema/schema.json
Updated .gitignore
Fixed Data Quality schemas that were not correct and added missing pieces
- Fixed the ordering of the components
- Evaluation Method
- object not array
- changed dateTime to an array to handle 2 dateTime values (start & end)
- Coverage Result
- Modified resultContent to be resultContentDescription which is a CoverageDescription object
- added new qualityResultFile schema
- changed resultFile to be the qualityResultFile
- resourceFormat changed to the format object
Added required fields / rules
Added descriptions
Range element description schema cleaned up

Testing

This version of the schema can be inspected with the schema viewer at the url below

http://23.23.4.125:8051/ (current version is 2.8.2-beta.7)

jwaspin commented 8 months ago

@dwalt & @hmaier-fws This PR is ready for review, but I'm not sure it 100% closes all those issues. I wasn't sure about a couple things like if all the scopes were required or just the top level one for data quality. Any small things I can fix immediately, but if we need some discussion on anything should we create new issues and close these ones?

One specific part to be aware of is the coverageResult class is listed in this PR, we might want to pull it out but there is an implementation for it so it might be better to create new issues to fix anything after we discuss the expected implementation (that's the one we were discussing the other day that needs to be reviewed).

jwaspin commented 8 months ago

Note that coverageResult has been updated and should be completed at this point. I did have to change some things based on what the schema looked like it should have been, those changes are noted in my comment followed by the modified description (which I've done in all the issues related to a new class if I had to change anything).

All of data quality should be done, so there are no known issues at this point.

jwaspin commented 8 months ago

In this issue: https://github.com/adiwg/mdJson-schemas/issues/262

It mentions "Translator UI not working, network error" but I'm not sure what this refers to. If I were to guess, this is actually an issue in mdTools, not mdJson-schemas, because that translator UI is not working, but there's already an issue for that in the mdTools repository.