search

adiwg / mdTranslator

Metadata translation tool built using Ruby
https://www.adiwg.org/mdTranslator/
The Unlicense
14 stars 12 forks source link

Breaking change in timeInterval #199

Closed jlblcc closed 6 years ago

jlblcc commented 6 years ago

The interval property in the mdJSON reader timeInterval module throws an error if the interval is not an integer. This is a breaking change! The current mdJSON schema example fails this test, which also means the mdJSON example is broken for downstream applications(mdTools). So we should probably issue a warning for this until 3.0.

See here: https://github.com/adiwg/mdTranslator/blob/c99791d8a9e7028650a44b0c87235ce5b8cf9618/lib/adiwg/mdtranslator/readers/mdJson/modules/module_timeInterval.rb#L33

jlblcc commented 6 years ago

I monkeypatched mdTools example until this is resolved.

stansmith907 commented 6 years ago

This is true. The ISO standard calls for integers. I double checked the documentation before adding these tests to the latest release. It also makes sense to require these fields as integers except possible for seconds. We should decide if we want mdJson act differently.

Sent from my iPhone

On Jul 23, 2018, at 4:15 PM, Josh Bradley notifications@github.com wrote:

I monkeypatched mdTools example until this is resolved.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

jlblcc commented 6 years ago

This has been fixed: 048466e0212143299fa308739ce6344d84cd07b8