adiwg / mdTranslator

Metadata translation tool built using Ruby
https://www.adiwg.org/mdTranslator/
The Unlicense
14 stars 12 forks source link

ISO-15115-2 outputs incorrect partentIdentifier #230

Open chris-macdermaid opened 2 years ago

chris-macdermaid commented 2 years ago

The mdTranslator sbJSON to ISO-19115-2 translation doesn't use the parentID present in the sbJSON input but instead uses the character string 'U.S. Geological Survey ScienceBase parent identifier'.

Example sbJSON

https://www.sciencebase.gov/catalog/item/5b465330e4b060350a15c6be?format=json

correctly identifies the parentId:

parentId    "5b46483be4b060350a15c5c4"      https://www.sciencebase.gov/catalog/item/5b46483be4b060350a15c5c4

Screenshot from 2022-09-07 11-56-49

Interestingly, if the sbJSON is translated to ISO-19115-1 mdTranslator correctly includes the parentId as part of the fuller parentMetadata!

sbj

dwalt commented 2 years ago

I'm wondering if this could be due to a strict -2 translation when the writer was originally developed that possibly did not recognize parent identifier as content? Or possibly an oversight.


From: Chris MacDermaid @.> Sent: Thursday, September 8, 2022 10:59 AM To: adiwg/mdTranslator @.> Cc: Subscribed @.***> Subject: [EXTERNAL] [adiwg/mdTranslator] ISO-15115-2 output partentIdentifier (Issue #230)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

The mdTranslator sbJSON to ISO-19115-2 translation doesn't use the parentID present in the sbJSON input but instead uses the character string 'U.S. Geological Survey ScienceBase parent identifier'.

Example sbJSON

https://www.sciencebase.gov/catalog/item/5b465330e4b060350a15c6be?format=jsonhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.sciencebase.gov%2Fcatalog%2Fitem%2F5b465330e4b060350a15c6be%3Fformat%3Djson&data=05%7C01%7Cdwalworth%40usgs.gov%7C0d39776b748247b6ed0108da91cc3b74%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637982603603360726%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6xRylZg5x1P5Uia1oBe51Z97VfDNU4uNagwa6z7%2FrDI%3D&reserved=0

correctly identifies the parentId:

parentId    "5b46483be4b060350a15c5c4"      https://www.sciencebase.gov/catalog/item/5b46483be4b060350a15c5c4https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.sciencebase.gov%2Fcatalog%2Fitem%2F5b46483be4b060350a15c5c4&data=05%7C01%7Cdwalworth%40usgs.gov%7C0d39776b748247b6ed0108da91cc3b74%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637982603603360726%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HPUWl3uHzSpjfBLc8YTFcc0qT5On0Vd5Ao5pabzfIQU%3D&reserved=0

[Screenshot from 2022-09-07 11-56-49]https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F64213093%2F189202990-d0114c02-e4ff-4656-8967-41a12d5e0aad.png&data=05%7C01%7Cdwalworth%40usgs.gov%7C0d39776b748247b6ed0108da91cc3b74%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637982603603360726%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=2IsMw8PSQLNmMVd3GQw5YL4wHGsWz3MeYvTyNVoO1q8%3D&reserved=0

Interestingly, if the sbJSON is translated to ISO-19115-1 mdTranslator correctly includes the parentId as part of the fuller parentMetadata!

[sbj]https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F64213093%2F189203252-07556686-4e7c-4723-998a-3f2167e3a961.png&data=05%7C01%7Cdwalworth%40usgs.gov%7C0d39776b748247b6ed0108da91cc3b74%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637982603603360726%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=A5dSczzNYXwk0D%2F3M5vgo6LJvd3qTdPRz5PArkEmYho%3D&reserved=0

— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadiwg%2FmdTranslator%2Fissues%2F230&data=05%7C01%7Cdwalworth%40usgs.gov%7C0d39776b748247b6ed0108da91cc3b74%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637982603603360726%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=8nuOW56WZW1BOMErVMFBW%2FA%2Bo%2FszEjFmJI37jiPvjGg%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABPKCLZIDXPIHWJDMMRGDWTV5IZP7ANCNFSM6AAAAAAQIBBOPU&data=05%7C01%7Cdwalworth%40usgs.gov%7C0d39776b748247b6ed0108da91cc3b74%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637982603603360726%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=nt%2BvGd4ARKHKr2SvNeFdIFOdw%2BO5ZG6fvxCJFqquNvk%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.***>