adiwg / mdTranslator

Metadata translation tool built using Ruby
https://www.adiwg.org/mdTranslator/
The Unlicense
14 stars 12 forks source link

CSDGM Writer - Orphaned End Tags #232

Closed dwalt closed 6 months ago

dwalt commented 2 years ago

End tags in the Distribution section are showing up absent beginning tags or content. This includes Technical Prerequisites (techpreq) and Resource Description (resdesc).

timothypage commented 2 years ago

@dwalt it looks like techpreq and resdesc are configured to always output an empty tag (<techpreq />)if they're empty, if thats what you mean?

I can either remove those lines or put it behind the "writerShowTags" configuration, like this

dwalt commented 2 years ago

It should not write empty tags, unless the "show empty tags" switch is set.


From: Tim Zwolak @.> Sent: Tuesday, October 18, 2022 1:12 PM To: adiwg/mdTranslator @.> Cc: Walworth, Dennis H @.>; Mention @.> Subject: [EXTERNAL] Re: [adiwg/mdTranslator] CSDGM Writer - Orphaned End Tags (Issue #232)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

@dwalthttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdwalt&data=05%7C01%7Cdwalworth%40usgs.gov%7Ccda50325c0804d487e7308dab14d874b%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638017243785862236%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eyJOOZbVTL1AdYfbH5cwYO2bVhNxk9afuLJcV3bxsdM%3D&reserved=0 it looks like techpreq and resdesc are configured to always output an empty tag ()if they're empty, if thats what you mean?

I can either remove those lines or put it behind the "writerShowTags" configuration, like thishttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadiwg%2FmdTranslator%2Fblob%2Fmaster%2Flib%2Fadiwg%2Fmdtranslator%2Fwriters%2Ffgdc%2Fclasses%2Fclass_distribution.rb%23L97-L99&data=05%7C01%7Cdwalworth%40usgs.gov%7Ccda50325c0804d487e7308dab14d874b%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638017243785862236%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=lSvDhk4b2Z%2BeWqdawLknj%2Fwwsy5M6PZPSxKCZ60ZShQ%3D&reserved=0

— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadiwg%2FmdTranslator%2Fissues%2F232%23issuecomment-1283009657&data=05%7C01%7Cdwalworth%40usgs.gov%7Ccda50325c0804d487e7308dab14d874b%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638017243785862236%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=m2JEZACwErrDi3RjNuBvE%2BM3m%2BfIquQtJB07a1TBzyk%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABPKCL6ISDPGFWB2UWVZSZDWD4HFLANCNFSM6AAAAAARCZZ75Q&data=05%7C01%7Cdwalworth%40usgs.gov%7Ccda50325c0804d487e7308dab14d874b%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638017243785862236%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jgnqhLQ1mf8deLt0t8ilT5KLcelOOgwIfQYSFYL1%2Bag%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

dwalt commented 1 year ago

mdJSON-CSDGM translated successfully in test

hmaier-fws commented 6 months ago

closed by #250