adiwg / mdTranslator

Metadata translation tool built using Ruby
https://www.adiwg.org/mdTranslator/
The Unlicense
14 stars 12 forks source link

Incorrect Scope Code Written to ISO #259

Closed dwalt closed 8 months ago

dwalt commented 1 year ago

-1 and -2 writers are writing a "dataset" Scope Code as "series". Problem noticed in Data Quality, not checked in other Scope Code usage.

jwaspin commented 10 months ago

Looks like I found the problem in the file lib/adiwg/mdtranslator/writers/iso19115_1/classes/class_dataQuality.rb

@xml.tag!('mdq:scope') do
  @xml.tag!('mcc:MD_Scope') do
    @xml.tag!('mcc:level') do
      @xml.tag!('mcc:MD_ScopeCode', codeList: "http://www.isotc211.org/2005/resources/Codelist/gmxCodelists.xml#MD_ScopeCode", codeListValue: "series")
    end
  end
end
jwaspin commented 9 months ago

@dwalt

<mdb:dataQualityInfo>
      <mdq:DQ_DataQuality>
         <mdq:scope>
            <mcc:MD_Scope>
               <mcc:level>
                  <mcc:MD_ScopeCode codeList="http://www.isotc211.org/2005/resources/Codelist/gmxCodelists.xml#MD_ScopeCode" codeListValue="series"/>
               </mcc:level>
            </mcc:MD_Scope>
         </mdq:scope>
      </mdq:DQ_DataQuality>
   </mdb:dataQualityInfo>

Is the issue just with the codeListValue? Or is that URL also wrong?

dwalt commented 9 months ago

No, the value is valid, but it is not what I selected from the drop-down list in the UI.

jwaspin commented 9 months ago

Sorry wrong word, meant to say incorrect as opposed to invalid. As long as it's just the value that doesn't match up with the selection from the drop-down then I think I should have this resolved in the morning.