search

adjtomo / pyadjoint

Measure waveform misfits and generate adjoint sources for a variety of measurement quantities
http://adjtomo.github.io/pyadjoint/
BSD 3-Clause "New" or "Revised" License
14 stars 26 forks source link

Added write_to_asdf method to write the adjoint source to an ASDF file using pyadsdf #1

Closed ghost closed 8 years ago

krischer commented 8 years ago

Look pretty good. I added some comments in line. Please also make sure the code is formatted correctly. You can see all the formatting errors if you run the tests:

$ python -m pyadjoint.tests
ghost commented 8 years ago

Thanks Lion, this is fixed now.

On Oct 21, 2015, at 3:33 AM, Lion Krischer notifications@github.com<mailto:notifications@github.com> wrote:

Look pretty good. I added some comments in line. Please also make sure the code is formatted correctly. You can see all the formatting errors if you run the tests:

$ python -m pyadjoint.tests

— Reply to this email directly or view it on GitHubhttps://github.com/krischer/pyadjoint/pull/1#issuecomment-149804930.

ghost commented 8 years ago

Hi Lion,

I think I fixed all these issues so if you could take another look at let me know if there are any problems with my fixes or additional issues that would be great.

Cheers, James

krischer commented 8 years ago

Looks good to me :-) The travis error is unrelated and I'll fix it after the merge.

krischer commented 8 years ago

At one point we will have to add a test by pyadjoint is not really stable enough yet to warrant that.