adjtomo / pyatoa

Python's Adjoint Tomography Operations Assistant (Pyatoa): a misfit assessment toolbox for full waveform tomography
GNU General Public License v3.0
20 stars 8 forks source link

'waveform' misfit naming mismatch with Pyadjoint #13

Closed bch0w closed 2 years ago

bch0w commented 2 years ago

Pyatoa's Config object expects the waveform misfit function to be input as 'waveform', but Pyadjoint expects this to be called 'waveform_misfit'. This mismatch causes Pyadjoint to throw the following error during the Manager.measure() task:

PyadjointError: Adjoint Source type 'waveform' is unknown. Available types: cc_traveltime_misfit, multitaper_misfit, waveform_misfit

To fix this, the Config object needs to be amended to set the adj_src_type for waveform misfit to be 'waveform_misfit' rather than waveform, which can be found in these code lines:

https://github.com/adjtomo/pyatoa/blob/fd33b8f48a005f29d6502c26fbb2fc3d73c9efc4/pyatoa/core/config.py#L745-L767