search

adjtomo / pyatoa

Python's Adjoint Tomography Operations Assistant (Pyatoa): a misfit assessment toolbox for full waveform tomography
GNU General Public License v3.0
20 stars 8 forks source link

move redundant I/O + data gathering functionality into PySEP #21

Closed bch0w closed 1 year ago

bch0w commented 2 years ago

PySEP and Pyatoa share a lot of read/write functionality for reading in SPECFEM-derived data (CMTSOLUTIONS, STATIONS files). A lot of the capabilities in PySEP were copied verbatim from Pyatoa and in many cases improved upon. Pyatoa's functionality has fallen behind w.r.t PySEP.

https://github.com/adjtomo/pysep/blob/master/pysep/utils/io.py https://github.com/adjtomo/pyatoa/blob/devel/pyatoa/utils/read.py

However this codebase is mostly redundant and does not really need to live on two packages in parallel. I think the best way forward would be to pick one package to keep these functions in, and then make that package a dependency of the other and import.

Probably since PySEP is smaller, we can make that the dependency. This would first involve publishing it on Pip (and Conda?) so that the routine installation of Pyatoa installs PySEP as a dependency. Should also make a corresponding issue in PySEP.

bch0w commented 1 year ago

See https://github.com/adjtomo/pysep/issues/56 for work plan on how this will take place

bch0w commented 1 year ago

Closed with #23 and https://github.com/adjtomo/pysep/pull/58