adjtomo / pyatoa

Python's Adjoint Tomography Operations Assistant (Pyatoa): a misfit assessment toolbox for full waveform tomography
GNU General Public License v3.0
20 stars 8 forks source link

Remove external data gathering and I/O routines from Pyatoa #23

Closed bch0w closed 1 year ago

bch0w commented 1 year ago

What does this PR do?

This PR strips out all external data gathering routines (i.e., calls to obspy.clients.fdsn.Client) and specfem-related I/O routines (reading/writing synthetics, cmtsolutions) from Pyatoa. These routines have been moved to PySEP (https://github.com/adjtomo/pysep/issues/56) in order to provide more user flexibility as they were too rigid within the workflow of Pyatoa and not easily used. PySEP has now been added as a dependency of Pyatoa in order to get the I/O routines back.

Why was it initiated? Any relevant Issues?

PySEP and Pyatoa share a lot of read/write functionality for reading in SPECFEM-derived data (CMTSOLUTIONS, STATIONS files). A lot of the capabilities in PySEP were copied verbatim from Pyatoa and in many cases improved upon. Pyatoa's functionality has fallen behind w.r.t PySEP so it makes sense to choose one of the packages to keep these routines in.

The reason for choosing PySEP is that its purpose is better suited for I/O and data collection, whereas Pyatoa is more of a misfit-quantification software.

Relevant Issue: https://github.com/adjtomo/pyatoa/issues/21, https://github.com/adjtomo/pysep/issues/56

PR Checklist