Removes abstraction from the Manager window function.
Previously, User's provided an argument to window(fix_windows: bool) to determine whether windows were selected, or re-used (from an ASDFDataSet). This was a bit too abstract
To be more explicit, the window() function only selects windows. A new function retrieve_windows_from_dataset is used in lieu of the window function in order to retrieve windows from a previous evaluation
Changelog:
Function Manager.window() is now only used for selecting new windows
Function Manager.retrieve_windows_from_dataset() is now used for selecting previously evaluated windows from an ASDFDataSet
Feature: Can now retrieve window by component, previously all windows in Dataset were returned
Adjusted Manager.flow function to deal with new setup
Misc Bugfix: Remove 'simple' detrend from preprocessing steps because it was causing processing artefacts on non-tapered data
Misc: function format_event_name can now handle all events output by PySEP's read_events_plus
Why was it initiated? Any relevant Issues?
Setting up for Pyatoa to be able to used manually selected windows by Users. This will come in a future PR
And to remove some obscurity from the processing workflow
PR Checklist
[x] develop base branch selected?
[x] This PR is not directly related to an existing issue (which has no PR yet).
[x] All tests still pass.
[x] Any new features or fixed regressions covered by new tests.
[ ] Any new or changed features have been fully documented.
[ ] Significant changes have been added to CHANGELOG.md.
[ ] First time contributors have added your name to CONTRIBUTORS.txt .
What does this PR do?
Motivation:
retrieve_windows_from_dataset
is used in lieu of the window function in order to retrieve windows from a previous evaluationChangelog:
Manager.window()
is now only used for selecting new windowsManager.retrieve_windows_from_dataset()
is now used for selecting previously evaluated windows from an ASDFDataSetManager.flow
function to deal with new setupformat_event_name
can now handle all events output by PySEP'sread_events_plus
Why was it initiated? Any relevant Issues?
PR Checklist
develop
base branch selected?CHANGELOG.md
.