Closed bch0w closed 7 months ago
Hi @mnagaso, the latest devel
branch should have some working examples for you to look at. Please let me know if you run into any other issues or have any questions! Thanks again for bringing this up!
Hello @bch0w,
Thank you very much for your immediate update for the examples! This PR is very helpful for me to understand the structure of the library and your recent updates! I am briefly trying to use seisflows. So I will be very happy if I will be able to make any futher feedbacks.
I very much like the abstruction of the code structure for using all the 3 varieties of Specfem with one library.
No problem! I appreciate your feedback so far, it'll be very useful to have your continued input on the code. And you can thank @rmodrak for the structure, the modular design he implemented has been really nice to work with as the package grows in complexity.
This PR fixes examples in the
devel
branch after some API changes had broken them, which includes updates and bugfixes to the Solver and Preprocessing modules. Currently all 3 examples are now working and generally matching previous results. Most importantly, fixes some critical bugs that were introduced to the Default preprocessing module in #181Change Log
Examples
Preprocessing
Bugfixes
trim
function was swapping obs and syn waveforms leading to incorrect misfit and adjoint sourcesSolver
generate_data
now saves synthetic observations to disk (path_data) and then copies over to scratch directoryGeneral Updates