search

adjust / cordova_sdk

This is the Cordova SDK of
http://www.adjust.com
MIT License
37 stars 43 forks source link

Build is failing #92

Closed samirpramanik closed 4 years ago

samirpramanik commented 5 years ago

We are facing a build issue, which was earlier working fine. We are using the version 4.14.0. The error is as below : No resource identifier found for attribute \'appComponentFactory\' in package \'android\'

uerceg commented 5 years ago

Hi @samirpramanik

Can you maybe provide more detailed build log output? I can't really see how can this be tied to our Cordova SDK at this moment.

samirpramanik commented 5 years ago

Sure. PFA the complete logs. adjustBuildFail.txt

uerceg commented 5 years ago

Hm. I am not sure how does this relate to Adjust SDK. Can you explain to me what makes you think that our SDK is source of the issue?

From what I see:

myWorkspace\cordovatemp\platforms\android\build\intermediates\manife
sts\full\debug\AndroidManifest.xml:27: AAPT: No resource identifier found for at
tribute 'appComponentFactory' in package 'android'

Seems like aapt is failing when processing your manifest file. What is in line 27 of it during this build process?

samirpramanik commented 5 years ago

We are seeing this issue only after we add the adjust sdk to our project. Please find attached the manifest file as well. In line 27, it has the following : <application android:appComponentFactory="androidx.core.app.CoreComponentFactory"

This earlier used to refer to v4 support factory. Now it refers to androidx.core.app.CoreComponentFactory. But there is no plugin change or dependencies change from our end. AndroidManifest .txt

uerceg commented 5 years ago

Thanks for info. Still not sure how this relates to our SDK. Will try to see if we can reproduce this behavior.

Which Cordova version and cordova-android platform version are you using?

samirpramanik commented 5 years ago

We are using cordova 8.0.0. Earlier we were on 6.5.0, but we upgraded and the issue still remains. Cordova android patform version is 6.1.2

uerceg commented 5 years ago

Thanks. We will try to see if we can reproduce this issue and keep you posted in here.

samirpramanik commented 5 years ago

Were you able to reproduce this? For us, it started suddenly. The same sdk was working perfectly before and we did not change even the versions.

uerceg commented 5 years ago

I still didn't manage to reproduce this issue even though I am using same environment you described. Does the same issue happen if you update cordova-android platform to latest version?

uerceg commented 4 years ago

@samirpramanik Any update on this one?

philippmayrth commented 4 years ago

For us, it started suddenly.

We are facing the same bug it also happened suddenly for us. When we remove Adjust it's building perfectly.

@samirpramanik How did you fix it?

samirpramanik commented 4 years ago

Enabling jetifier and using androidx helped us resolve this issue at our end.

uerceg commented 4 years ago

@philippmayrth Did this solution work for you?