Compatiblity with Gradle 8.0

adjust / flutter_sdk

This is the Flutter SDK of

MIT License

58 stars 49 forks source link

Compatiblity with Gradle 8.0 #107

Closed agacemi closed 9 months ago

agacemi commented 1 year ago

We try to upgrade to Android Gradle Plugin 8.0. Build fails with the fellowing error due to breaking change in AGP: namespace is mandatory. https://developer.android.com/build/releases/gradle-plugin#namespace-dsl

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':adjust_sdk'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Please specify a namespace in the module's build.gradle file like so:

     android {
         namespace 'com.example.namespace'
     }

     If the package attribute is specified in the source AndroidManifest.xml, it can be migrated automatically to the namespace value in the build.gradle file using the AGP Upgrade Assistant; please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information.

dihsarjr commented 1 year ago

I am also facing the same issue.

FAILURE: Build failed with an exception.

What went wrong: A problem occurred configuring project ':adjust_sdk'.

Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl. Namespace not specified. Please specify a namespace in the module's build.gradle file like so:

android { namespace 'com.example.namespace' }

If the package attribute is specified in the source AndroidManifest.xml, it can be migrated automatically to the namespace value in the build.gradle file using the AGP Upgrade Assistant; please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information.
Try:

Run with --info or --debug option to get more log output. Run with --scan to get full insights.

daiki1003 commented 1 year ago

anything update?

agacemi commented 1 year ago

Any update ? We can't upgrade to Gradle 8.0 due to this error

daiki1003 commented 1 year ago

Do we have to remove adjust sdk...?

uerceg commented 1 year ago

Hey guys,

Thank you for reporting this and sorry for the delay. We'll take a look and keep you posted.

daiki1003 commented 1 year ago

Thanks! I know this is a lot of work, but thank you in advance!

uerceg commented 1 year ago

Hey guys, sorry for a bit of delay on this one. We have just released v4.34.0 which should hopefully make the plugin compatible with Gradle 8.0++. If you can please give it a shot and let us know if it worked, that would be great. Cheers.