search

adjust / istore

development repo for integer hstore replacement in postgres
MIT License
35 stars 3 forks source link

build failure with postgresql-12 #92

Open patricklauer opened 4 years ago

patricklauer commented 4 years ago

version 0.1.6 doesn't seem to appreciate pg-12:

src/bigistore.c:580:58: error: unknown type name ‘FunctionCallInfoData’; did you mean ‘FunctionCallInfoBaseData’?
  580 | setup_firstcall(FuncCallContext *funcctx, BigIStore *is, FunctionCallInfoData *fcinfo)
      |                                                          ^~~~~~~~~~~~~~~~~~~~
      |                                                          FunctionCallInfoBaseData
src/istore.c:579:55: error: unknown type name ‘FunctionCallInfoData’; did you mean ‘FunctionCallInfoBaseData’?
  579 | setup_firstcall(FuncCallContext *funcctx, IStore *is, FunctionCallInfoData *fcinfo)
      |                                                       ^~~~~~~~~~~~~~~~~~~~
      |                                                       FunctionCallInfoBaseData
src/bigistore.c: In function ‘bigistore_each’:
src/bigistore.c:621:9: warning: implicit declaration of function ‘setup_firstcall’ [-Wimplicit-function-declaration]
  621 |         setup_firstcall(funcctx, is, fcinfo);
      |         ^~~~~~~~~~~~~~~
src/istore.c: In function ‘istore_each’:
src/istore.c:620:9: warning: implicit declaration of function ‘setup_firstcall’ [-Wimplicit-function-declaration]
  620 |         setup_firstcall(funcctx, is, fcinfo);
      |         ^~~~~~~~~~~~~~~
make: *** [<builtin>: src/bigistore.o] Error 1
make: *** Waiting for unfinished jobs....
make: *** [<builtin>: src/istore.o] Error
zilder commented 4 years ago

I’ll look into this

zilder commented 4 years ago

Actually it should be fine to use the latest binary with older SQLs. Since v0.1.6 only a few new functions were added. Old functions were slightly refactored without API changes (or with backward compatibility; the only such change i found is a new input format for istores in v0.1.11). Master branch is compatible with pg12 and builds ok. @patricklauer, can you try to use binary from master?

patricklauer commented 4 years ago

Current master builds without issue, so best to make a new release

zilder commented 4 years ago

I created a new release on github. Do you want me to add a new version to gentoo-overlay?