search

adjust / parquet_fdw

Parquet foreign data wrapper for PostgreSQL
PostgreSQL License
333 stars 37 forks source link

Import foreign schema #18

Closed zilder closed 4 years ago

zilder commented 4 years ago

This PR is based on the issue #16. Description can be found in README.md ("Import" section). In short this PR introduces a function for importing few parquet files into a single foreign table. Which parquet files to import is defined by a user-provided custom function.

Pull request is quite big, i had to refactor most of the code to support multiple files in foreign table. There are likely bugs and code style issues.

alexeyklyukin commented 4 years ago

Hi,

Great job! it looks good, and the tests pass. Does it make sense to include floating-point types and NULLs in the test?

As a note I had to #include in parquet_impl.cpp to compile it on MacOS (this header is required on Linux as well, but perhaps it is included by some other header there).

I'll comment additionally on the code if I find any issues with it.