New Wrapper for cluster as in ISSUE #113

adjust / rmq

Message queue system written in Go and backed by Redis

MIT License

1.56k stars 205 forks source link

New Wrapper for cluster as in ISSUE #113 #128

Closed zcqzcg closed 8 months ago

zcqzcg commented 2 years ago

Hi team, Thanks to the authors to provide such a nice and effective rmq for Gophers!

I'm using this packge and have to work with a redis cluster, so I forked and added a new RedisClusterWrapper for the cluster to fit in.

NewWrapper for cluster
Rename original wrapper as SingleWrapper also the filename
Open redis connection with *redis.Option which could allow users to connect their redis more freely
Added/modified some tests roughly for the cluster testing.

Please feel free to modify/update these commits

==================== And a big thanks to ISSUE #113 , @obh provided a direction to the cluster path

Best, David

zcqzcg commented 1 year ago

Still needs working, will make PR later

QuanTran91 commented 1 year ago

How is it going with this PR? I got an issue in which I cannot use the rmq in cluster mode.

wellle commented 1 year ago

@zcqzcg: Are you still working on this? If not, maybe someone else can pick up this PR and try to address the review comments above 🙏

zcqzcg commented 1 year ago

@zcqzcg: Are you still working on this? If not, maybe someone else can pick up this PR and try to address the review comments above 🙏

SoSorry I haven't have enough time to work with this repo for now. Please if someone could take over

wellle commented 1 year ago

Thanks for the update!

Any takers? 🙏

wellle commented 8 months ago

Seeing the conversation in #113 I feel like this may have been resolved by the changes made related to Redis Cluster. I'm closing it as I'm not sure if this problem still persists. Please feel free to reopen if it does :v: