search

adjust / unity_sdk

This is the Unity SDK of
http://www.adjust.com
MIT License
149 stars 70 forks source link

[Question] (Deeplink)Android URL Scheme Definition Not Very Well #266

Open CodeMasterYi opened 1 year ago

CodeMasterYi commented 1 year ago

In AdjustEditorPreprocessor.cs there is an method AddURISchemes,

  1. We find you add android:host attribute to the scheme data node, while README.md says you should write them with :// part at the end(no host)
  2. according to Android Document About Deeplink screenshot including two scheme data node in one intent filter is not very nice for instance: in one intent filter, there is an https scheme with host a.example.com and an my_app scheme with host b.example.com. we can use https://b.example.com and my_app://a.example.com(They are not expected.)
CodeMasterYi commented 1 year ago

image

CodeMasterYi commented 1 year ago

My modification in AdjustEditorPreprocessor.cs(Left is yours, right is mine): image image

CodeMasterYi commented 1 year ago

See PR https://github.com/adjust/unity_sdk/pull/267

CodeMasterYi commented 1 year ago

Any reply?