search

adjust / web_sdk

40 stars 25 forks source link

Wrong type implemented on typescript strict mode #59

Open segux opened 2 days ago

segux commented 2 days ago

Actually typescript is throwing this error on 5.7.0 version

✘ [ERROR] TS2420: Class 'ThirdPartySharing' incorrectly implements interface 'ThirdPartySharingOptions'.
  Type 'ThirdPartySharing' is missing the following properties from type 'ThirdPartySharingOptions': isEnabled, granularOptions, partnerSharingSettings [plugin angular-compiler]

    node_modules/@adjustcom/adjust-web-sdk/dist/adjust-latest.d.ts:124:8:
      124 │   class ThirdPartySharing implements ThirdPartySharingOptions {
          ╵         ~~~~~~~~~~~~~~~~~
YaraMatkova commented 1 day ago

Hi @segux, thank you for letting know!

The fix should be available on npm. Feel free to give it a try, and let us know if you face any issues or have any further questions.