search

adkron / grovepi

Use the GrovePi in Elixir
Apache License 2.0
47 stars 9 forks source link

Fix typo in GrovePi.Button documentation #19

Closed axelclark closed 7 years ago

axelclark commented 7 years ago

I found a typo in the GrovePi.Button documentation.

axelclark commented 7 years ago

I also finished my LED Fade project with GrovePi.Poller implementation for the potentiometer.

https://github.com/axelclark/led_fade

fhunleth commented 7 years ago

@axelclark Thanks again for the typo fix!

@adkron Since the potentiometer is a standard component, what do you think about asking Axel to send a PR with the potientiometer poller implementation over here? Also, the LED fader sounds like a good example project to add as well.

adkron commented 7 years ago

That would be great! @axelclark, was everything simple to follow?

axelclark commented 7 years ago

@fhunleth and @adkron I'll start working on the pull request. The project is awesome! I'm really excited to help out on it!

The modules to read the sensors were very simple to follow. The Poller and Trigger modules took me a bit to figure out, but now that I understand how they work, it makes sense. The GrovePi.Button has better documentation than Poller module which was a little confusing for me at first. Also it might be helpful to explain the need for a Trigger module in the Poller documentation. When I look at it again, I might propose some updates that could make it easier to understand.