search

adkron / grovepi

Use the GrovePi in Elixir
Apache License 2.0
47 stars 9 forks source link

Update RGBLCD module #28

Closed axelclark closed 7 years ago

axelclark commented 7 years ago

WORK IN PROGRESS. Will probably be very busy at work through Sept, but figured I'd show you what I have so far.

I'm working to update the RGBLCD module using a C++ library and the datasheet.

References

Most of the functions work. Use GrovePi.RGBLCD.start to initialize.

There is a bug in the GrovePi.RGBLCD.blink_on, GrovePi.RGBLCD.blink_off, GrovePi.RGBLCD.cursor_blink_on, and GrovePi.RGBLCD.blink_off I have not been able to figure out. These commands work within the GrovePi.RGBLCD.startfunction, but don't work on their own.

I don't think GrovePi.RGBLCD.autoscroll works.

Also updated the home weather with new RGBLCD functions.

adkron commented 7 years ago

This is looking really good so far. Thank you for all the work you are putting into it. I don't have the stuff to test this right now, but I'm looking forward to trying it out.

axelclark commented 7 years ago

I figured out the bugs, so all of the functions are working now. I created a file to demonstrate the functionality. It is currently at lib/grovepi/rgblcd/examples.ex. I'm happy to delete it or move it depending on where you think it would fit best. I used the examples to make sure the updates work with hardware, but I don't have any automated tests at this point.

This is the biggest update I've made to a library so any suggestions for improvement are welcome.

adkron commented 7 years ago

@axelclark, I haven't had the time to check this, but it is looking good. I think that moving the examples module to /examples/rgblcd.ex or somewhere under that examples directory would be a good place to move it. I'm excited to play with this tonight.

axelclark commented 7 years ago

I moved the demo functions out into an example project. Let me know what else you'd like me to update. No rush, I know you are enjoying ElixirConf!!

adkron commented 7 years ago

Wish you were here so we could catch up. Next time!

Amos King Binary Noggin

On Sep 8, 2017, at 17:32, Axel Clark notifications@github.com wrote:

I moved the demo functions out into an example project. Let me know what else you'd like me to update. No rush, I know you are enjoying ElixirConf!!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

adkron commented 7 years ago

This looks good. I spent some time playing with it this morning. I'm going to mash it and do a new release. Thanks, @axelclark.

🤖 ❤️