Review 1 enhancements - Githubissues

adl1995 commented 6 years ago

Following issue #1, this pull request aims to introduce the following changes:

[x] Reorganize code to fit in a single header file
[ ] Use C++ templates to allow for different data types e.g. user should be able to provide input in DMS, DMM, DD
[x] Implement the more accurate Vincenty's formula
[x] Test the implementation against Boost Geometry algorithms
[x] Add a variety of test data
[x] Generalize repeated code from tests

adl1995 commented 6 years ago

@vissarion I have implemented the Vincenty's formula and tested my code against Boost Geometry distance algorithms. The strategies I have used are: Vincenty, Andoyer, and Thomas.

I am getting correct results with all the strategies. However, I noticed that I had to provide latitude and longitude in reverse order i.e.

  spherical_point point1(120.335066 /* longitude */, 23.205402 /* latitude */);

I'm not sure why this design was chosen. I have my exams starting from tomorrow. So, I will complete the remaining tasks once I get free.

Thanks!

adl1995 commented 6 years ago

Thank you for the review! I have merged this branch into master. I will make further changes in a separate branch.

adl1995 / geolib

Review 1 enhancements #3