search

adlez27 / phonetic-songs

Transcribing song lyrics to X-SAMPA
GNU General Public License v3.0
6 stars 2 forks source link

Fetcher API Usage #6

Closed VocAddict closed 4 years ago

VocAddict commented 4 years ago

Currently, it uses the API for AZLyrics but I've been thinking of adding on more (VocaDB is a must since you most likely aren't going to find Vocaloid songs on normal lyric sites) to give a the user a bit of a choice. I mentioned it in #5 but I may as well make an issue here to keep track of it further down the road. Of course, we'll have a recommended one based on our internal testing and maybe even eventually completely phase out the others if not needed.

APIs:

  1. AZLyrics (implemented, some bugs in terms of searching and encoding to hammer out)
  2. VocaDB (and related DBs that work on the same API; JSON)
  3. Genius (JSON)
  4. MetroLyrics (Python, so hopefully pretty similar to AZL)

There also the collection of billboard songs aren't difficult to do, we may just have to decide just how far back we want to go in terms of collection. After that, it's just to automate fetcher to read the artist name and song title and retrieve the lyrics.

VocAddict commented 4 years ago

I thought it was my coding but the same code with the same parameters yielded two different results for azapi and I'm starting to wonder if the way the requests are phrased to the API is to blame for this because at this point, I'm not even sure any more.

image

VocAddict commented 4 years ago

Submitted a bug report for azapi so hopefully we get some news on that soon. For now I'll work on implementing the other APIs.

VocAddict commented 4 years ago

Implemented tswift which is the API for MetroLyrics fetching. Holding off from a PR until I deal with the other two.

VocAddict commented 4 years ago

Added the following:

  1. VocaDB - 4f65ee01d3685ea6f4cc6cae6b3ec6ee934e586f
  2. UtaiteDB - eeebb810cb77e27f1ddd8e635ac5a4830ed3b643
  3. TouhouDB - 193f3443ac91f819cfaf5a1e9087269822ccfaa3
  4. Genius - f5e246a3c853b7ed61906dc89005c77f3cd20c5a May replace the Genius implementation with this in the future for better code keeping

Also decoupled dependency checks from the scripts - b376cd0d6bc3de738fd2af6c4d9980227d33cf64

I would add Piapro in a few days once I analyse how the site is written.

VocAddict commented 4 years ago

azapi 3.0.0 - https://github.com/adlez27/phonetic-songs/commit/50fc38b5ebcd0ac175b8abf4e54d79d9fc2b5f43

This fixes the issues that we had with it in terms of consistency, I'm still analysing piapro's site. This issue will be closed when that is done.

VocAddict commented 4 years ago

Piparo - 987f992e35f8f7bd578e06f03537b0a1e09d9387