search

adlio / trello

Trello API wrapper for Go
MIT License
220 stars 71 forks source link

Case on https://github.com/sirupsen/logrus import #1

Closed wcarmon closed 7 years ago

wcarmon commented 7 years ago

It looks like you are using lower case instead of upper case for the import.

This causes compiler errors that look like: case-insensitive import collision: "vendor/github.com/Sirupsen/logrus" and "vendor/github.com/sirupsen/logrus"

Their examples use upper case: https://github.com/sirupsen/logrus. It looks like they reverted the brief change to lower case a while back:

adlio commented 7 years ago

Erggg... that change was right between the switch from Upper to lower and back to upper as I was building this library. I'm going to replace logrus with an interface to allow optionally plugging in a debug logger, since we're exclusively using logrus for Debugf statements at this point.

wcarmon commented 7 years ago

ok, I'm using vendoring so I just changed it locally.
Hopefully this helps anyone that runs into the same issue.

Thanks for building a great library by the way!